docs: Authors, Series & Categories browse/manage pages (bookshelf-eseay.6) #1360
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "bd-bookshelf-eseay.6"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
docs/content/docs/your-library/authors-series-categories.mdcovering all three sidebar browse pagesdocs/content/docs/your-library/_index.mdTest plan
Closes bead bookshelf-eseay.6 on merge.
Security Review — PR #1360 (bookshelf-eseay.6)
Scope verification: The diff is strictly confined to two Markdown documentation files:
docs/content/docs/your-library/_index.md(one line added, a card link)docs/content/docs/your-library/authors-series-categories.md(new file, 128 lines, Markdown only)No production Go code, SQL, templates, JS, or configuration was touched. No secrets or tokens present.
Permission framing audit: The doc consistently frames rename/merge/delete actions as requiring "library management permissions" and explicitly states the ⋮ menu and merge checkboxes are only visible to users who have that permission. This is verified against the source: all three manage handler route files (
internal/authors/routes.go,internal/series/routes.go,internal/categories/routes.go) gate mutation endpoints (PATCH,POST /merge,DELETE) behind themanageRequiredmiddleware, which resolves tomanage_metadata_config(or admin). The doc does not imply unprivileged users can perform these actions.No unsafe guidance. No PII or secrets. No cross-user leak implied.
REVIEW VERDICT: 0 blocker, 0 major, 0 minor
Code/accuracy review of PR #1360 (bookshelf-eseay.6) per
.claude/rules/review-standard.md.[MAJOR] docs/content/docs/your-library/authors-series-categories.md:26 — Author photo described as a link to the detail page, but it is not clickable
The doc says "Clicking their card photo opens the author's own detail page." The actual
authors_index.htmltemplate wraps the photo in a plain<div class="author-card-photo-wrap">, not an<a>tag. No JS controller adds a click handler that navigates to/authors/{id}. The only link on each author card is the author's name, which goes to/books?author_id=...(the filtered book list), not to the author detail page. There is no path from the authors index to the individual author detail page in the current UI at all.Fix: change the sentence to reflect that the author's name is the only link on the card, and that it leads to the filtered book list. Remove the claim about clicking the photo. If a link to the detail page is intended but not yet wired, note it as "coming soon" rather than describing it as functional.
[MAJOR] docs/content/docs/your-library/authors-series-categories.md:29-32 — "Search Author" tab described as functional; it is a stub
The doc describes the Search Author tab with functional details: "lets you look up the author by name on Audnexus and pull in a biography and photo. Type a name, click Search, review the results, and click Apply on the match you want." The actual
author_show.htmltemplate at line 108 renders the panel as<p class="empty-state">Search Author coming soon.</p>. There is no Search input, no Search button, and no Apply button in the current UI. This is a stub.Fix: match the "Edit Details" treatment — write "Search Author — coming soon." instead of describing the interaction as implemented.
[MINOR] docs/content/docs/your-library/authors-series-categories.md:87 — Category kebab menu described as having per-card "Merge" action; it does not
The category ⋮ menu only has Rename and Delete (see
category_manage_controller.jslines 198-200). The merge feature for categories is bulk-only (via checkbox selection), not available per-card. The doc correctly describes the bulk merge flow later in the section, but the opening phrase "The actions available are: From the ⋮ menu (one category at a time): Rename / Delete" is accurate. The doc does not say "Merge" is in the category ⋮ menu — this is fine. Disregard; on re-read, no finding here.[MINOR] docs/content/docs/your-library/authors-series-categories.md:48 — Series section says "primary author" is shown on the card, but that field is conditional
The template (
series_index.htmlline 40-43) shows{{if .FirstAuthor}}<p class="series-card-author">{{.FirstAuthor}}</p>{{end}}— the author is only displayed when present. The doc states it as always present ("the series name, the primary author, and a badge with the book count"). Should say "the primary author (when known)" or similar.REVIEW VERDICT: 0 blocker, 2 major, 1 minor
c8c37f8c291e0f4851041e0f485104b09473deda