ci: wire PR number + token into e2e-browser job for screenshot auto-post (bookshelf-qy9b) #809

Merged

zombor merged 2 commits from bd-bookshelf-qy9b into main 2026-06-28 20:12:07 +00:00

Conversation 8 Commits 2 Files changed 4 +94 -6

zombor commented 2026-06-28 19:04:06 +00:00

Owner

Copy link

Summary

• Added PULL_REQUEST_NUMBER (from github.event.pull_request.number) and FORGEJO_TOKEN (from secrets.FORGEJO_TOKEN) to the e2e-browser step's env block in .forgejo/workflows/ci.yml.
• These two env vars are the pre-conditions for e2e/screenshotscope.ShouldPost to post a screenshot to a PR.
• A third guard (SCREENSHOT_JOURNEY) remains unset in CI, so the full browser suite never dumps every journey's screenshot onto a PR — a targeted journey run must set it explicitly (see screenshotscope.ShouldPost and the package-level doc comment for the three-var pattern).
• PULL_REQUEST_NUMBER is empty on push/main runs, so non-PR CI stays clean — the helper already no-ops when it is empty.

FORGEJO_TOKEN secret caveat

One manual step required by the repo owner: FORGEJO_TOKEN must exist as a repo secret in Forgejo (Settings → Actions → Secrets) with PR-comment write scope. If the secret is absent, the post still no-ops gracefully (no CI failure), but screenshot auto-post will not work until the secret is added.

Test plan

• CI passes (no change to Go/JS test code — only the step env block is modified).
• On a future UI PR, set SCREENSHOT_JOURNEY=<slug> in a targeted go test run; screenshot appears in the PR comment thread automatically.

Closes bead bookshelf-qy9b on merge.

## Summary - Added `PULL_REQUEST_NUMBER` (from `github.event.pull_request.number`) and `FORGEJO_TOKEN` (from `secrets.FORGEJO_TOKEN`) to the `e2e-browser` step's env block in `.forgejo/workflows/ci.yml`. - These two env vars are the pre-conditions for `e2e/screenshotscope.ShouldPost` to post a screenshot to a PR. - A **third guard** (`SCREENSHOT_JOURNEY`) remains unset in CI, so the full browser suite never dumps every journey's screenshot onto a PR — a targeted journey run must set it explicitly (see `screenshotscope.ShouldPost` and the package-level doc comment for the three-var pattern). - `PULL_REQUEST_NUMBER` is empty on push/main runs, so non-PR CI stays clean — the helper already no-ops when it is empty. ## FORGEJO_TOKEN secret caveat **One manual step required by the repo owner:** `FORGEJO_TOKEN` must exist as a repo secret in Forgejo (`Settings → Actions → Secrets`) with PR-comment write scope. If the secret is absent, the post still no-ops gracefully (no CI failure), but screenshot auto-post will not work until the secret is added. ## Test plan - [ ] CI passes (no change to Go/JS test code — only the step env block is modified). - [ ] On a future UI PR, set `SCREENSHOT_JOURNEY=<slug>` in a targeted `go test` run; screenshot appears in the PR comment thread automatically. Closes bead bookshelf-qy9b on merge.

recompute-match-score-kebab-open.png

109 KiB

wf-detail-older-execution.png

55 KiB

recompute-match-score-kebab-open.png

109 KiB

wf-detail-older-execution.png

55 KiB

zombor added 1 commit 2026-06-28 19:04:06 +00:00

ci: wire PULL_REQUEST_NUMBER + FORGEJO_TOKEN into e2e-browser job (bookshelf-qy9b) ... cfded123fb

The e2e-browser step env was missing PULL_REQUEST_NUMBER and FORGEJO_TOKEN,
so the in-test screenshot-post helper (e2e/screenshotscope.ShouldPost) always
no-op'd in CI — forcing manual local screenshot capture for every UI PR.

Wire both into the step env:
- PULL_REQUEST_NUMBER from github.event.pull_request.number (empty on push/main
  runs; helper no-ops when empty, so non-PR CI runs stay clean)
- FORGEJO_TOKEN from secrets.FORGEJO_TOKEN (graceful no-op if secret absent)

A third guard (SCREENSHOT_JOURNEY) in ShouldPost still prevents the full suite
from dumping every journey's screenshot onto a PR — that env var must be set
explicitly per-journey for any post to occur.

NOTE: FORGEJO_TOKEN repo secret must be created in Forgejo (Settings → Actions →
Secrets) with PR-comment write scope for auto-post to work in practice.

forgejo-actions commented 2026-06-28 19:06:28 +00:00

Copy link

Recompute Match Score — kebab open screenshot (recompute-match-score-kebab-open)

**Recompute Match Score — kebab open screenshot** (recompute-match-score-kebab-open) 

forgejo-actions commented 2026-06-28 19:06:44 +00:00

Copy link

Workflow Detail page screenshot (wf-detail-older-execution)

Older completed ContinueAsNew epoch detail — execution ID and state visible, Cancel absent.

**Workflow Detail page screenshot** (wf-detail-older-execution) Older completed ContinueAsNew epoch detail — execution ID and state visible, Cancel absent. 

zombor commented 2026-06-28 19:12:23 +00:00

Author

Owner

Copy link

[MAJOR] .forgejo/workflows/ci.yml:314-315 — Screenshot auto-post goal not achieved; SCREENSHOT_JOURNEY env var missing

The bead's stated goal ("UI screenshot auto-post stops no-op'ing") requires all THREE env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, and SCREENSHOT_JOURNEY. ShouldPost (e2e/screenshotscope/scope.go:51) gates posting on all three being non-empty:

  if token == "" || prNum == "" || targetJourney == "" {
    return false
  }

This PR wires the first two but leaves SCREENSHOT_JOURNEY unset in CI. Without it, shouldPostJourneyScreenshot returns false on every journey, so uploadJourneyScreenshotToPR still no-ops even on PR runs. The comments in the PR even acknowledge this: "without it the full suite never auto-posts even with these two set" — which describes the current state after merge.

For screenshots to actually auto-post on a normal UI PR CI run, SCREENSHOT_JOURNEY must be set to the target journey slug. Current options:

• (a) Set SCREENSHOT_JOURNEY per-journey via separate CI job(s) or a test-selection mechanism (e.g., run one specific Ginkgo journey with SCREENSHOT_JOURNEY=$journey_slug)
• (b) Implement a branch-name or label-based trigger to conditionally set SCREENSHOT_JOURNEY
• (c) Have tests read a .screenshot-journey config file or similar

Without one of these, the feature remains incomplete and UI teams still need manual capture + post (same as pre-PR state).

---

Technical verification (APPROVED):

• Env var names match code expectations: ✓ (PULL_REQUEST_NUMBER, FORGEJO_TOKEN)
• Syntax correct for Forgejo Actions: ✓ (${{ github.event.pull_request.number }} is valid)
• Graceful handling on push/main runs: ✓ (prNum empty on non-PR triggers, ShouldPost returns false)
• YAML valid: ✓
• No secrets leaked: ✓

---

REVIEW VERDICT: 1 major, 0 blocker, 0 minor

[MAJOR] .forgejo/workflows/ci.yml:314-315 — Screenshot auto-post goal not achieved; SCREENSHOT_JOURNEY env var missing The bead's stated goal ("UI screenshot auto-post stops no-op'ing") requires all THREE env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, and SCREENSHOT_JOURNEY. ShouldPost (e2e/screenshotscope/scope.go:51) gates posting on all three being non-empty: ``` if token == "" || prNum == "" || targetJourney == "" { return false } ``` This PR wires the first two but leaves SCREENSHOT_JOURNEY unset in CI. Without it, shouldPostJourneyScreenshot returns false on every journey, so uploadJourneyScreenshotToPR still no-ops even on PR runs. The comments in the PR even acknowledge this: "without it the full suite never auto-posts even with these two set" — which describes the current state after merge. For screenshots to actually auto-post on a normal UI PR CI run, SCREENSHOT_JOURNEY must be set to the target journey slug. Current options: - (a) Set SCREENSHOT_JOURNEY per-journey via separate CI job(s) or a test-selection mechanism (e.g., run one specific Ginkgo journey with SCREENSHOT_JOURNEY=$journey_slug) - (b) Implement a branch-name or label-based trigger to conditionally set SCREENSHOT_JOURNEY - (c) Have tests read a .screenshot-journey config file or similar Without one of these, the feature remains incomplete and UI teams still need manual capture + post (same as pre-PR state). --- **Technical verification (APPROVED):** - Env var names match code expectations: ✓ (PULL_REQUEST_NUMBER, FORGEJO_TOKEN) - Syntax correct for Forgejo Actions: ✓ (${{ github.event.pull_request.number }} is valid) - Graceful handling on push/main runs: ✓ (prNum empty on non-PR triggers, ShouldPost returns false) - YAML valid: ✓ - No secrets leaked: ✓ --- REVIEW VERDICT: 1 major, 0 blocker, 0 minor

zombor force-pushed bd-bookshelf-qy9b from cfded123fb to 03420ebfb2 2026-06-28 19:24:36 +00:00 Compare

forgejo-actions commented 2026-06-28 19:27:25 +00:00

Copy link

Recompute Match Score — kebab open screenshot (recompute-match-score-kebab-open)

**Recompute Match Score — kebab open screenshot** (recompute-match-score-kebab-open) 

forgejo-actions commented 2026-06-28 19:27:59 +00:00

Copy link

Workflow Detail page screenshot (wf-detail-older-execution)

Older completed ContinueAsNew epoch detail — execution ID and state visible, Cancel absent.

**Workflow Detail page screenshot** (wf-detail-older-execution) Older completed ContinueAsNew epoch detail — execution ID and state visible, Cancel absent. 

zombor commented 2026-06-28 19:29:47 +00:00

Author

Owner

Copy link

MAJOR fix: [shot:<slug>] PR title marker now wires SCREENSHOT_JOURNEY automatically

The code review flagged that wiring only PULL_REQUEST_NUMBER + FORGEJO_TOKEN was insufficient — screenshotscope.ShouldPost has a three-var gate and SCREENSHOT_JOURNEY was never set in CI, so no screenshot ever auto-posted.

What changed (commit 03420ebf)

A new step "Extract screenshot journey slug from PR title" runs before make e2e-browser. It parses [shot:<slug>] from the PR title using sed and writes SCREENSHOT_JOURNEY=<slug> to $GITHUB_ENV. The run step picks it up via ${{ env.SCREENSHOT_JOURNEY }}.

Convention for UI PRs

Include [shot:<slug>] anywhere in the PR title — the slug must match the string passed to uploadJourneyScreenshotToPR in the journey test:

"Add stats page [shot:library-stats] (bookshelf-xyz)"

That is all. CI extracts the slug, the three-var gate opens for exactly that journey, and only that screenshot posts to the PR.

Why not a committed file?

A committed .screenshot-journey file would be inherited by every branch subsequently branched from main and cause stale screenshots from a different PR to be posted on unrelated PRs. The PR title is PR-scoped by design — it never persists to main.

Non-UI PRs / push runs

No [shot:…] marker → SCREENSHOT_JOURNEY stays unset → ShouldPost returns false → nothing posts. The full e2e suite is safe to run on every PR without screenshot pollution.

CI

Green at 03420ebf — all checks pass.

## MAJOR fix: `[shot:<slug>]` PR title marker now wires `SCREENSHOT_JOURNEY` automatically The code review flagged that wiring only `PULL_REQUEST_NUMBER` + `FORGEJO_TOKEN` was insufficient — `screenshotscope.ShouldPost` has a **three-var gate** and `SCREENSHOT_JOURNEY` was never set in CI, so no screenshot ever auto-posted. ### What changed (commit `03420ebf`) A new step **"Extract screenshot journey slug from PR title"** runs before `make e2e-browser`. It parses `[shot:<slug>]` from the PR title using `sed` and writes `SCREENSHOT_JOURNEY=<slug>` to `$GITHUB_ENV`. The run step picks it up via `${{ env.SCREENSHOT_JOURNEY }}`. ### Convention for UI PRs Include `[shot:<slug>]` anywhere in the PR title — the slug must match the string passed to `uploadJourneyScreenshotToPR` in the journey test: ``` "Add stats page [shot:library-stats] (bookshelf-xyz)" ``` That is all. CI extracts the slug, the three-var gate opens for exactly that journey, and only that screenshot posts to the PR. ### Why not a committed file? A committed `.screenshot-journey` file would be inherited by every branch subsequently branched from `main` and cause stale screenshots from a different PR to be posted on unrelated PRs. The PR title is PR-scoped by design — it never persists to `main`. ### Non-UI PRs / push runs No `[shot:…]` marker → `SCREENSHOT_JOURNEY` stays unset → `ShouldPost` returns `false` → nothing posts. The full e2e suite is safe to run on every PR without screenshot pollution. ### CI Green at `03420ebf` — all checks pass.

zombor commented 2026-06-28 19:54:37 +00:00

Author

Owner

Copy link

CODE REVIEW: MAJOR RESOLUTION VERIFIED

Phase 0: DEMO Verification

N/A — this is a CI/workflow infrastructure fix with no end-user DEMO.

Phase 1: Spec Compliance

Prior MAJOR (from previous review): SCREENSHOT_JOURNEY environment variable was unset, allowing ANY journey's screenshot to post when PULL_REQUEST_NUMBER and FORGEJO_TOKEN were set. This caused cross-PR pollution (PR #776 accumulated 38 stray screenshots).

Fix implemented (commits 03420ebf + 4a8c5eae):

1. New CI step "Extract screenshot journey slug from PR title" parses [shot:<slug>] from github.event.pull_request.title
2. Exports SCREENSHOT_JOURNEY to $GITHUB_ENV when a marker exists; unset otherwise
3. e2e-browser job now receives all three env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, SCREENSHOT_JOURNEY
4. screenshotscope.ShouldPost gate requires ALL three to be non-empty AND targetJourney == journeySlug

Verification of the fix:

1. sed extraction regex is correct and safe (.forgejo/workflows/ci.yml:305)

   • Pattern: sed -n 's/.*\[shot:\([^]]*\)\].*/\1/p'
   • Tested: [shot:library-stats] → library-stats ✓
   • No marker: empty string (safe) ✓
   • Bash quoting: printf '%s' "$PR_TITLE" prevents injection ✓

2. PR-scoped, non-persisting (e2e/screenshotscope/scope.go:20–38, .forgejo/workflows/ci.yml:292–312)

   • Slug sourced ONLY from github.event.pull_request.title (runtime context), NOT a committed file ✓
   • No .screenshot-journey or similar file committed ✓
   • Verified via git ls-tree -r bd-bookshelf-qy9b | grep -i screenshot — only code files, no data files ✓

3. Robustness on non-PR/push runs

   • On push/main: github.event.pull_request.title is empty → slug is empty → SCREENSHOT_JOURNEY stays unset → ShouldPost returns false for all journeys (clean no-op) ✓
   • Non-UI PRs (no [shot:…] marker): same behavior ✓
   • sed doesn't crash on missing brackets; bash if [ -n "$slug" ] safely gates the export ✓

4. Documentation comprehensive (e2e/screenshotscope/scope.go + docs/content/docs/developer/testing.md)

   • Package doc clearly explains the three-var gate and PR title convention ✓
   • Testing.md explains contributor workflow: add [shot:<slug>] to PR title ✓
   • Dev docs mention FORGEJO_TOKEN must be added as a repo secret ✓

5. Tests verify the gate logic (e2e/screenshotscope/scope_test.go)

   • DescribeTable covers: missing fields, mismatches, successful matches ✓
   • Case sensitivity enforced ✓
   • Exact string match required ✓

Phase 2: Code Quality

• Bash correctness: Shell syntax is sound; printf + sed is shell-safe, >> is proper append to $GITHUB_ENV ✓
• Go correctness: ShouldPost gate is straightforward three-way AND + equality check ✓
• No regressions: Existing journeys that don't set SCREENSHOT_JOURNEY now safely no-op (were broken before, now unbroken) ✓

RESOLUTION VERDICT

The MAJOR is RESOLVED. The three-variable gate (token AND prNum AND targetJourney match) is now enforced at the gating function (screenshotscope.ShouldPost), and SCREENSHOT_JOURNEY is populated from the PR title via sed extraction in the CI step — eliminating cross-PR pollution. When a UI PR includes [shot:<slug>] in its title, only that journey's screenshot posts. Non-UI PRs and push/main runs produce no screenshots.

---

REVIEW VERDICT: 0 blocker, 0 major, 0 minor

## CODE REVIEW: MAJOR RESOLUTION VERIFIED ### Phase 0: DEMO Verification N/A — this is a CI/workflow infrastructure fix with no end-user DEMO. ### Phase 1: Spec Compliance **Prior MAJOR (from previous review):** SCREENSHOT_JOURNEY environment variable was unset, allowing ANY journey's screenshot to post when PULL_REQUEST_NUMBER and FORGEJO_TOKEN were set. This caused cross-PR pollution (PR #776 accumulated 38 stray screenshots). **Fix implemented (commits 03420ebf + 4a8c5eae):** 1. New CI step "Extract screenshot journey slug from PR title" parses `[shot:<slug>]` from `github.event.pull_request.title` 2. Exports SCREENSHOT_JOURNEY to $GITHUB_ENV when a marker exists; unset otherwise 3. e2e-browser job now receives all three env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, SCREENSHOT_JOURNEY 4. screenshotscope.ShouldPost gate requires ALL three to be non-empty AND targetJourney == journeySlug **Verification of the fix:** 1. **sed extraction regex is correct and safe** (.forgejo/workflows/ci.yml:305) - Pattern: `sed -n 's/.*\[shot:\([^]]*\)\].*/\1/p'` - Tested: `[shot:library-stats]` → `library-stats` ✓ - No marker: empty string (safe) ✓ - Bash quoting: `printf '%s' "$PR_TITLE"` prevents injection ✓ 2. **PR-scoped, non-persisting** (e2e/screenshotscope/scope.go:20–38, .forgejo/workflows/ci.yml:292–312) - Slug sourced ONLY from `github.event.pull_request.title` (runtime context), NOT a committed file ✓ - No `.screenshot-journey` or similar file committed ✓ - Verified via `git ls-tree -r bd-bookshelf-qy9b | grep -i screenshot` — only code files, no data files ✓ 3. **Robustness on non-PR/push runs** - On push/main: `github.event.pull_request.title` is empty → `slug` is empty → `SCREENSHOT_JOURNEY` stays unset → `ShouldPost` returns false for all journeys (clean no-op) ✓ - Non-UI PRs (no `[shot:…]` marker): same behavior ✓ - sed doesn't crash on missing brackets; bash `if [ -n "$slug" ]` safely gates the export ✓ 4. **Documentation comprehensive** (e2e/screenshotscope/scope.go + docs/content/docs/developer/testing.md) - Package doc clearly explains the three-var gate and PR title convention ✓ - Testing.md explains contributor workflow: add `[shot:<slug>]` to PR title ✓ - Dev docs mention FORGEJO_TOKEN must be added as a repo secret ✓ 5. **Tests verify the gate logic** (e2e/screenshotscope/scope_test.go) - DescribeTable covers: missing fields, mismatches, successful matches ✓ - Case sensitivity enforced ✓ - Exact string match required ✓ ### Phase 2: Code Quality - **Bash correctness:** Shell syntax is sound; `printf` + `sed` is shell-safe, `>>` is proper append to $GITHUB_ENV ✓ - **Go correctness:** ShouldPost gate is straightforward three-way AND + equality check ✓ - **No regressions:** Existing journeys that don't set SCREENSHOT_JOURNEY now safely no-op (were broken before, now unbroken) ✓ ### RESOLUTION VERDICT The MAJOR is **RESOLVED**. The three-variable gate (`token` AND `prNum` AND `targetJourney` match) is now enforced at the gating function (screenshotscope.ShouldPost), and SCREENSHOT_JOURNEY is populated from the PR title via sed extraction in the CI step — eliminating cross-PR pollution. When a UI PR includes `[shot:<slug>]` in its title, only that journey's screenshot posts. Non-UI PRs and push/main runs produce no screenshots. --- **REVIEW VERDICT: 0 blocker, 0 major, 0 minor**

zombor commented 2026-06-28 19:54:49 +00:00

Author

Owner

Copy link

CODE REVIEW: MAJOR RESOLUTION VERIFIED

Phase 0: DEMO Verification

N/A — this is a CI/workflow infrastructure fix with no end-user DEMO.

Phase 1: Spec Compliance

Prior MAJOR (from previous review): SCREENSHOT_JOURNEY environment variable was unset, allowing ANY journey's screenshot to post when PULL_REQUEST_NUMBER and FORGEJO_TOKEN were set. This caused cross-PR pollution (PR #776 accumulated 38 stray screenshots).

Fix implemented (commits 03420ebf + 4a8c5eae):

1. New CI step extracts [shot:<slug>] from PR title and exports SCREENSHOT_JOURNEY to $GITHUB_ENV
2. e2e-browser job receives all three env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, SCREENSHOT_JOURNEY
3. screenshotscope.ShouldPost gate requires ALL three non-empty AND targetJourney == journeySlug

Verification:

1. sed regex is correct and safe (.forgejo/workflows/ci.yml:305)

   • Pattern: sed -n 's/.*\[shot:\([^]]*\)\].*/\1/p'
   • Extracts slug correctly; empty when no marker; bash-safe with printf '%s'

2. PR-scoped, non-persisting (e2e/screenshotscope/scope.go, .forgejo/workflows/ci.yml)

   • Slug from github.event.pull_request.title (runtime), NOT a committed file
   • No .screenshot-journey file found in tree

3. Robustness on non-PR/push runs

   • On push/main: PR title is empty → SCREENSHOT_JOURNEY unset → ShouldPost returns false (clean no-op)
   • sed doesn't crash; bash gates safely with if [ -n "$slug" ]

4. Documentation (scope.go + testing.md)

   • Package doc explains three-var gate and PR title convention
   • Contributors learn to add [shot:<slug>] to PR title
   • FORGEJO_TOKEN secret requirement documented

5. Tests (scope_test.go)

   • Missing-field cases covered
   • Mismatch cases covered (different journey, partial match, case sensitivity)
   • Successful-match cases covered

RESOLUTION VERDICT

The MAJOR is RESOLVED. The three-variable gate is now enforced, and SCREENSHOT_JOURNEY is populated from PR title via sed extraction. Only the targeted journey posts; others safely no-op.

---

REVIEW VERDICT: 0 blocker, 0 major, 0 minor

## CODE REVIEW: MAJOR RESOLUTION VERIFIED ### Phase 0: DEMO Verification N/A — this is a CI/workflow infrastructure fix with no end-user DEMO. ### Phase 1: Spec Compliance **Prior MAJOR (from previous review):** SCREENSHOT_JOURNEY environment variable was unset, allowing ANY journey's screenshot to post when PULL_REQUEST_NUMBER and FORGEJO_TOKEN were set. This caused cross-PR pollution (PR #776 accumulated 38 stray screenshots). **Fix implemented (commits 03420ebf + 4a8c5eae):** 1. New CI step extracts `[shot:<slug>]` from PR title and exports SCREENSHOT_JOURNEY to $GITHUB_ENV 2. e2e-browser job receives all three env vars: PULL_REQUEST_NUMBER, FORGEJO_TOKEN, SCREENSHOT_JOURNEY 3. screenshotscope.ShouldPost gate requires ALL three non-empty AND targetJourney == journeySlug **Verification:** 1. **sed regex is correct and safe** (.forgejo/workflows/ci.yml:305) - Pattern: `sed -n 's/.*\[shot:\([^]]*\)\].*/\1/p'` - Extracts slug correctly; empty when no marker; bash-safe with `printf '%s'` 2. **PR-scoped, non-persisting** (e2e/screenshotscope/scope.go, .forgejo/workflows/ci.yml) - Slug from `github.event.pull_request.title` (runtime), NOT a committed file - No `.screenshot-journey` file found in tree 3. **Robustness on non-PR/push runs** - On push/main: PR title is empty → SCREENSHOT_JOURNEY unset → ShouldPost returns false (clean no-op) - sed doesn't crash; bash gates safely with `if [ -n "$slug" ]` 4. **Documentation** (scope.go + testing.md) - Package doc explains three-var gate and PR title convention - Contributors learn to add `[shot:<slug>]` to PR title - FORGEJO_TOKEN secret requirement documented 5. **Tests** (scope_test.go) - Missing-field cases covered - Mismatch cases covered (different journey, partial match, case sensitivity) - Successful-match cases covered ### RESOLUTION VERDICT The MAJOR is **RESOLVED**. The three-variable gate is now enforced, and SCREENSHOT_JOURNEY is populated from PR title via sed extraction. Only the targeted journey posts; others safely no-op. --- **REVIEW VERDICT: 0 blocker, 0 major, 0 minor**

zombor merged commit 7885ef3278 into main 2026-06-28 20:12:07 +00:00

zombor referenced this pull request from a commit 2026-06-28 20:12:08 +00:00

Merge pull request 'ci: wire PR number + token into e2e-browser job for screenshot auto-post (bookshelf-qy9b)' (#809) from bd-bookshelf-qy9b into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

zombor/pergamum!809

No description provided.